Conversation
sidepelican
commented
Apr 25, 2024
|
|
||
| public static func jsonName(entityName: String) -> String { | ||
| return "\(entityName)_JSON" | ||
| return "\(entityName)$JSON" |
omochi
approved these changes
Apr 25, 2024
Owner
omochi
left a comment
There was a problem hiding this comment.
ありがとうございます
小さな変更に対して見かけの差分が派手だ。
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
以下のようなコードにおいて、重複したシンボルが生成されるという問題があります。
FooのTS側JSON型としてFoo_JSONが。Foo.JSONのTS側Entity型としてFoo_JSONが生成され、衝突します。この問題の原因は、ネームスペース結合の記号とJSON型のSuffix結合の記号が同一の
_であることだと思います。片方の結合に用いる記号を変更することで回避ができます。
もちろん、Swift側の型名で
_や$が使われていた場合に似たような壊れが起こると思いますが、それは特殊なケースなので諦めます。